[PATCH] D74687: [LLD][ELF] - Linker script: do not fail parsing when "/DISCARD/" follows the fill expression.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 06:24:01 PST 2020


grimar added a comment.

In D74687#1878409 <https://reviews.llvm.org/D74687#1878409>, @MaskRay wrote:

> Do we have a more elegant fix:) ?


Do you have something particular in mind? The only thing I can think of is to treat '\n' as an expression terminator.
I am not sure it is a right thing to do. I think that `tokenizeExpr` used in this diff is a correct place for such fix.
It has elegant name FWIW..


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74687/new/

https://reviews.llvm.org/D74687





More information about the llvm-commits mailing list