[llvm] d6fe253 - llvm: Use quotes around MSVC_DIA_SDK_DIR CMake variable

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 04:46:09 PST 2020


Author: Cristian Adam
Date: 2020-02-18T14:42:19+02:00
New Revision: d6fe253653b7e760f94ca21d0a7ebbfeeee28777

URL: https://github.com/llvm/llvm-project/commit/d6fe253653b7e760f94ca21d0a7ebbfeeee28777
DIFF: https://github.com/llvm/llvm-project/commit/d6fe253653b7e760f94ca21d0a7ebbfeeee28777.diff

LOG: llvm: Use quotes around MSVC_DIA_SDK_DIR CMake variable

MSVC_DIA_SDK_DIR variable will point to a path which contains spaces,
and without quotes it will fail to configure the project.

Added: 
    

Modified: 
    llvm/cmake/config-ix.cmake

Removed: 
    


################################################################################
diff  --git a/llvm/cmake/config-ix.cmake b/llvm/cmake/config-ix.cmake
index a16038f70989..fc66dbfcbe7a 100644
--- a/llvm/cmake/config-ix.cmake
+++ b/llvm/cmake/config-ix.cmake
@@ -469,7 +469,7 @@ if( MSVC )
   # though that we should handle it.  We do so by simply checking that
   # the DIA SDK folder exists.  Should this happen you will need to
   # uninstall VS 2012 and then re-install VS 2013.
-  if (IS_DIRECTORY ${MSVC_DIA_SDK_DIR})
+  if (IS_DIRECTORY "${MSVC_DIA_SDK_DIR}")
     set(HAVE_DIA_SDK 1)
   else()
     set(HAVE_DIA_SDK 0)


        


More information about the llvm-commits mailing list