[PATCH] D74611: [obj2yaml][WIP] - Fix indentations in the ELF output.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Overall, the process seems sound and simple. That probably makes it the right thing to do here. Some comments explaining each step of the post-processing would be useful though. Also, should this really be restricted to ELF?



================
Comment at: llvm/test/tools/obj2yaml/elf-output-indentation.yaml:2
+## obj2yaml tries to optimize indentations between keys and
+## values to make an output nicer.
+## In this test we demonstrate the output produced.
----------------
an output -> the output


================
Comment at: llvm/test/tools/obj2yaml/elf-output-indentation.yaml:40
+
+## Use an arbitrary YAML with different fields.
+
----------------
Use an arbitrary YAML document
or
Use arbitrary YAML

would be better English. However, I think what you really want to say is something like "Use a YAML document with arbitrary fields and values to show how the indentation is affected."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74611/new/

https://reviews.llvm.org/D74611