[PATCH] D74595: [llvm-readobj] - Report warnings instead of errors for broken relocations.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/relocation-errors.test:55-58
+## Case 2: Test that no warning is reported for a relocation against a symbol with index 0.
+      - Offset: 0x2
+        Symbol: 0
+        Type:   R_X86_64_NONE
----------------
jhenderson wrote:
> Seems like this overlaps with reloc-no-sym.test? Could we get rid of one or the other?
This one is a bit different: here we have a SHT_REL section. 
(I can't test an addend here, like `reloc-no-sym.test` do).

And the intention to have it also was to show the order of warnings/normal relocations.
I.e. I wanted to have at least one valid relocation in the middle and
"relocation against a symbol with index 0" works good as it is related to the context and the
current code.

So, I'd keep both. (btw, `reloc-no-sym.test` seems lacks GNU test and SHT_REL test and might need to be improved).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74595/new/

https://reviews.llvm.org/D74595