[PATCH] D74228: [PatternMatch] Match XOR variant of unsigned-add overflow check.

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

I'd like to see (at least?) the commutative case handled.



================
Comment at: llvm/include/llvm/IR/PatternMatch.h:1712
+      Value *Op1;
+      if (m_OneUse(m_Xor(m_Value(Op1), m_AllOnes())).match(ICmpLHS))
+        return L.match(Op1) && R.match(ICmpRHS) && S.match(ICmpLHS);
----------------
Hm, i don't really see one-use checks in similar neighboring patterns here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74228/new/

https://reviews.llvm.org/D74228