[PATCH] D74141: [InstCombine] Simplify a umul overflow check to a != 0 && b != 0.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 245037.
fhahn added a comment.

Match m_oneuse(m_extract<1>) || m_oneuse(m_ICmp(Pred, m_oneuse(m_ExtractValue<0>)) as suggested.

I'm not sure if there's a nicer way to do that, e.g. binding parts of a pattern to a new name, so we can do the use checks later?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74141/new/

https://reviews.llvm.org/D74141

Files:
  llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
  llvm/test/Transforms/InstCombine/umul-sign-check.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74141.245037.patch
Type: text/x-patch
Size: 6781 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200217/1f2e371a/attachment.bin>