[PATCH] D74738: Revert "[GISel]: Fix incorrect IRTranslation while translating null pointer types"

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 17 12:11:44 PST 2020


arsenm created this revision.
arsenm added reviewers: aditya_nandakumar, aemerson, dsanders, volkan, paquette, Petar.Avramovic.
Herald added subscribers: hiraditya, wdng.
Herald added a project: LLVM.
arsenm added a commit: rGb3297ef05179: [GISel]: Fix incorrect IRTranslation while translating null pointer types.

This reverts commit b3297ef05179e1fee616b97b1c65b58e4c7fef17.

      

This change is incorrect. The current semantic of null in the IR is a
pointer with the bitvalue 0. It is not a cast from an integer 0, so
this should preserve the pointer type.


https://reviews.llvm.org/D74738

Files:
  llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
  llvm/test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll
  llvm/test/CodeGen/AArch64/GlobalISel/arm64-irtranslator-switch.ll
  llvm/test/CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll
  llvm/test/CodeGen/AArch64/GlobalISel/call-translator-tail-call.ll
  llvm/test/CodeGen/AArch64/GlobalISel/call-translator.ll
  llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-exceptions.ll
  llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-tbaa.ll
  llvm/test/CodeGen/AArch64/GlobalISel/swifterror.ll
  llvm/test/CodeGen/AArch64/GlobalISel/translate-gep.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74738.245023.patch
Type: text/x-patch
Size: 19025 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200217/f7448c12/attachment.bin>


More information about the llvm-commits mailing list