[PATCH] D74730: [FPEnv][X86] Implement lowering of llvm.set.rounding

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:25790
+  Chain = CWD.getValue(1);
+  APInt Mask(16, 0xf3ff);
+  CWD = DAG.getNode(ISD::AND, DL, MVT::i16, CWD.getValue(0),
----------------
Why do we need an APInt?


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:25859
+    Chain = CWD.getValue(1);
+    APInt Mask(32, 0xffff9fff);
+    CWD = DAG.getNode(ISD::AND, DL, MVT::i32, CWD.getValue(0),
----------------
Why do we need an APInt?


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:25873
+    // Load MXCSR from the slot.
+//     SDValue OpsLDSSE[] = { Chain, StackSlot };
+//     MachineMemOperand *MMOL_SSE =
----------------
Removed commented out code.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:30134
+  NODE_NAME_CASE(FLDCW16m)
+  NODE_NAME_CASE(FNSTSW16r)
   NODE_NAME_CASE(LCMPXCHG_DAG)
----------------
Where did FNSTSW16r come from? I deleted that recently.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.h:660
+      /// Stores MXCSR into memory.
+      STMXCSR,
+
----------------
STMXCSR/LDMXCSR aren't used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74730/new/

https://reviews.llvm.org/D74730