[PATCH] D73995: [NFC] [DA] Refactoring getIndexExpressionsFromGEP

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 17 10:03:22 PST 2020


Meinersbur accepted this revision.
Meinersbur added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:11452
+  }
+  return;
+}
----------------
[style] It might be useful to return true here and false at the bail-outs. Otherwise, the `return` here is redundant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73995/new/

https://reviews.llvm.org/D73995





More information about the llvm-commits mailing list