[PATCH] D74614: [CSInfo][TailDuplicator] Update the call site info

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 17 01:34:09 PST 2020


djtodoro added a comment.

> So perhaps we should just call MachineFunction::copyCallSiteInfo within CloneMachineInstr, if the original MI may have a call site entry?

This sounds good to me, but I'll investigate that to see if we should call the `eraseCallSiteInfo` as well.

> Btw if you're interested in tackling that, perhaps it'd be best to split things into multiple patches (so, land the removeDeadBlock change from this patch, enable entry values, then keep on iterating)?

Nice, I agree.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74614/new/

https://reviews.llvm.org/D74614





More information about the llvm-commits mailing list