[PATCH] D74169: [WIP][LLD][ELF][DebugInfo] Skeleton implementation of removing obsolete debug info.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 16 14:25:56 PST 2020


MaskRay added a comment.

I agree with

> if the additional complexity is not too much, and the new code is nicely isolated from existing code. I think I agree with you that linker is perhaps the best place to drop dead DWARF info.

(One thing I plan to work on is .debug_names accelerator table, which is similar to but more power than `.gdb_index`.)

On one side, I've heard thoughts that: if we use -gsplit-dwarf, is .debug* garbage collection still valuable?
On the other side, I think this approach may be better than D54747 <https://reviews.llvm.org/D54747> (reverted by rL360955 <https://reviews.llvm.org/rL360955>) and may address the problem it tried to mitigate. Given the savings, we may bend our mind a bit and give more tolerance even if the additional complexity is more than `not too much`.

I am reluctant to let individual patches in before we can see the benefits, because they could easily turn out to be insufficient and cluttered the history.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74169/new/

https://reviews.llvm.org/D74169





More information about the llvm-commits mailing list