[PATCH] D74360: [llvm][TableGen] Define FieldInit::isConcrete overload

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 16 11:32:45 PST 2020


rriddle added a comment.

In D74360#1878327 <https://reviews.llvm.org/D74360#1878327>, @nhaehnle wrote:

> Do you have a concrete example where this is used? I would have expected the A1.value to be resolved... the non-resolve-behavior was only kept around for bits in instruction encodings (Resolver::keepUnsetBits).


This happens in MLIR where we use tablegen quite a bit, e.g. for defining operations.

https://github.com/llvm/llvm-project/blob/272d35aef5e0d32f12b700ea12c608e0323ceb3f/mlir/include/mlir/IR/OpBase.td#L683
https://github.com/llvm/llvm-project/blob/272d35aef5e0d32f12b700ea12c608e0323ceb3f/mlir/include/mlir/IR/OpBase.td#L636


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74360/new/

https://reviews.llvm.org/D74360





More information about the llvm-commits mailing list