[PATCH] D74671: [AMDGPU] Use generated RegisterPressureSets enum

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 16 09:15:28 PST 2020


rampitec added a comment.

In D74671#1878105 <https://reviews.llvm.org/D74671#1878105>, @nhaehnle wrote:

> LGTM. I agree with Matt that it would be great not to create those other pressure sets in the first place, possibly by adding some .td file construct to explicitly list the ones that are required. That said, this change is clearly a step in the right direction.


We need only 2 or maybe 3 of psets, and this makes a lot of sense to add a syntax to explicitly request psets, but even then we need an enum to identify these 2 or 3. I.e. I agree as well, but the change is orthogonal.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74671/new/

https://reviews.llvm.org/D74671





More information about the llvm-commits mailing list