[PATCH] D74527: AMDGPU/GlobalISel: Support llvm.trap intrinsic

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 16 08:12:31 PST 2020


arsenm added a comment.

In D74527#1878103 <https://reviews.llvm.org/D74527#1878103>, @hsmhsm wrote:

> Based on the review comments by arsenm, I have moved handling of trap and debugtrap intrinsics to Legazizer, and submitted a new Phabricator review request - https://reviews.llvm.org/D74688.  Hence closing this review request.


You could also have just updated this one with a new diff, instead of creating a separate review. Splitting the review usually makes it harder to track


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74527/new/

https://reviews.llvm.org/D74527





More information about the llvm-commits mailing list