[PATCH] D73835: [IRBuilder] Virtualize IRBuilder

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 16 05:40:05 PST 2020


nikic marked an inline comment as done.
nikic added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetFolder.h:32
 /// TargetFolder - Create constants with target dependent folding.
-class TargetFolder {
+class TargetFolder : public IRBuilderFolder {
   const DataLayout &DL;
----------------
nhaehnle wrote:
> Could we make the TargetFolder final?
Yeah, don't see a reason not to... can always drop it again if someone is extending these for some reason.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73835/new/

https://reviews.llvm.org/D73835





More information about the llvm-commits mailing list