[PATCH] D74595: [llvm-readobj] - Report warnings instead of errors for broken relocations.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 16 04:33:08 PST 2020


grimar added inline comments.


================
Comment at: llvm/test/Object/invalid.test:420
 
-# RUN: yaml2obj %s --docnum=21 -o %t21
-# RUN: llvm-readobj --dynamic-table %t21 2>&1 | FileCheck -DFILE=%t21 --check-prefix=INVALID-DTSTRTAB %s
+# RUN: yaml2obj %s --docnum=20 -o %t20
+# RUN: llvm-readobj --dynamic-table %t20 2>&1 | FileCheck -DFILE=%t20 --check-prefix=INVALID-DTSTRTAB %s
----------------
MaskRay wrote:
> We probably should split `invalid.test`. For example, segments related errors and sections related errors can be separated.
It feels that some of the tests might go to the corresponding tools test folders.
(e.g. docnum 21 below)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74595/new/

https://reviews.llvm.org/D74595





More information about the llvm-commits mailing list