[PATCH] D74679: [SCCP] Skip unknown values depending on tracked functions.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/SCCP.cpp:1446
 /// method should be use to handle this.  If this returns true, the solver
 /// should be rerun.
 ///
----------------
Out of scope: Isn't branch on `undef` UB?


================
Comment at: llvm/test/Transforms/SCCP/resolvedundefsin-tracked-fn.ll:1
-; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --function-signature
 ; RUN: opt -ipsccp -S %s | FileCheck %s
----------------
Nit: You should probably do an NFC commit first to add the --function-signatures


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74679/new/

https://reviews.llvm.org/D74679