[PATCH] D74545: [llvm-readobj] - Refactor the code that dumps relocations.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 14 21:46:43 PST 2020


MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1068
+
+  if (Sym->getType() == ELF::STT_SECTION) {
+    Expected<const Elf_Shdr *> SecOrErr =
----------------
Add a comment about what this `if` block does.

The st_name field of a STT_SECTION is usually 0 (empty string). This code block returns the section name.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74545/new/

https://reviews.llvm.org/D74545





More information about the llvm-commits mailing list