[PATCH] D73674: Propeller: LLVM support for basic block sections (Base Patch - Part 2)

Rahman Lavaee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 14 16:48:47 PST 2020


rahmanl added a comment.

In D73674#1868439 <https://reviews.llvm.org/D73674#1868439>, @efriedma wrote:

> Is there some reason to emit "cold" and "exception" blocks into separate sections?  Not sure what benefit you get from separating them.


Great point Eli!
As @tmsriram mentioned, in the case where hot eh pads are present, this allows us to reorder the exception section and place it in the hot part.
However, I modified the code such that if all eh pads are cold, we don't create a separate exception section and group all eh pads together with the cold section. The next patch update by @tmsriram  will include this change. A test will also be included in D73739 <https://reviews.llvm.org/D73739>.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73674/new/

https://reviews.llvm.org/D73674





More information about the llvm-commits mailing list