[PATCH] D74614: [CSInfo][TailDuplicator] Update the call site info

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 14 15:16:09 PST 2020


vsk added a comment.

FWIW, I applied this patch as well as D73534 <https://reviews.llvm.org/D73534>, then backed out the changes introduced here in duplicateSimpleBB and tailDuplicate, and got a clean check-llvm run (except for the test added here, which asserts that 'callSites' is empty). Did you notice some other test failing?

Note that we primarily use TailDuplicator::duplicateInstruction to copy instructions. That calls MachineFunction::CloneMachineInstr (via TargetInstrInfo::duplicate -> CloneMachineInstrBundle).

So perhaps we should just call MachineFunction::copyCallSiteInfo within CloneMachineInstr, if the original MI may have a call site entry?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74614/new/

https://reviews.llvm.org/D74614





More information about the llvm-commits mailing list