[PATCH] D74599: llvm: Set WINVER to 0x601 (Windows 7) for MinGW

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D74599#1876507 <https://reviews.llvm.org/D74599#1876507>, @amccarth wrote:

> In D74599#1875984 <https://reviews.llvm.org/D74599#1875984>, @mstorsjo wrote:
>
> >   you could just as well make it Windows 7 (which is the documented minimum version).
>
>
> The documented minimum version for CompareStringOrdinal is Vista per https://docs.microsoft.com/en-us/windows/win32/api/stringapiset/nf-stringapiset-comparestringordinal
>
> Are you talking about the documented minimum version of something else?


I'm talking about the fact that LLVM is documented to require at least Windows 7, when targeting that platform (i.e. it's ok to unconditionally use APIs that became available only since Windows 7 throughout the core LLVM code).

Normally mingw headers only expose functions that exist since XP (contrary to the official WinSDKs that by default expose everything from the latest version), but by setting this define, we make those functions visible that are conditionally visible from Vista or Win7. Even though it seemed to be enough to raise it to Vista for this particular function, I suggested to raise it to the same level as what LLVM is documented to require, so we don't need to raise it again if someone adds a call to a function that appeared in Win7.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74599/new/

https://reviews.llvm.org/D74599