[PATCH] D74632: [AArch64][SVE] Add initial backend support for FP splat_vector

[Cameron McInally via Phabricator via llvm-commits]

cameron.mcinally created this revision.
cameron.mcinally added reviewers: sdesmalen, kmclaughlin, dancgr, rengolin, efriedma, huntergr.
Herald added subscribers: llvm-commits, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett.
Herald added a project: LLVM.

This issue was found in D73711 <https://reviews.llvm.org/D73711>.

We'll also need separate changes to CodeGen wrt splat_vectors. There are some incorrect uses of scalable build_vectors (int and fp) scattered there. This is obvious when an assert to check for scalable build_vectors is added to `DAG.getNode(...)`.

Notice the TODO in the f16 immediate splat tests. There seems to be a missing lowering for f16 constants. Instead of becoming ConstantFPs, the f16 constants are being explicitly loaded from the constant pool. Does anyone know where the special f16 constant lowerings live? I don't have a lot of experience with those.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74632

Files:
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/lib/Target/AArch64/AArch64InstrFormats.td
  llvm/lib/Target/AArch64/AArch64InstrInfo.cpp
  llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
  llvm/test/CodeGen/AArch64/vector-splat-sve.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74632.244716.patch
Type: text/x-patch
Size: 9678 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200214/fcc37cc9/attachment.bin>