[PATCH] D74448: [scudo][standalone] Allow setting release to OS

Christopher Ferris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 14 10:58:00 PST 2020


cferris added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/wrappers_c.inc:165
+        value = INT32_MIN;
+        secondary_interval = INT32_MIN;
+      } else {
----------------
cryptoad wrote:
> Now that value & secondary_interval have the same values, does it make sense to merge them?
Good point, I've removed the ability to set the two differently since it's not needed now, and I'm not sure if it's something we'll want in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74448/new/

https://reviews.llvm.org/D74448





More information about the llvm-commits mailing list