[PATCH] D74614: [CSInfo][TailDuplicator] Update the call site info

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: llvm/lib/CodeGen/TailDuplicator.cpp:739
+        MF->eraseCallSiteInfo(&MI);
+    });
+
----------------
Ditto, not sure why this isn't covered by the change in `removeDeadBlock`?


================
Comment at: llvm/lib/CodeGen/TailDuplicator.cpp:867
+        MF->eraseCallSiteInfo(&MI);
+    });
+
----------------
Why is this change necessary? I think this part of `tailDuplicate` just duplicates the contents of TailBB into PredBB. The deletion doesn't look like it happens until we get back to `tailDuplicateAndUpdate`, in `removeDeadBlock`.

If anything I'd expect that we'd have to `copyCallSiteInfo` here. I'll dig into this some more, I easily might be missing something.


================
Comment at: llvm/lib/CodeGen/TailDuplicator.cpp:1037
+      MF->eraseCallSiteInfo(&MI);
+  });
+
----------------
This makes sense to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74614/new/

https://reviews.llvm.org/D74614