[PATCH] D74621: ValueTracking: Fix crash on weird size bswap

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 14 10:03:30 PST 2020


RKSimon added a comment.

In D74621#1876606 <https://reviews.llvm.org/D74621#1876606>, @nikic wrote:

> Sure, non-byte multiplies doesn't make sense, but byte multiples generally do. However, after checking LangRef we apparently do require the bitwidth to be a multiple of 16 for this intrinsic: https://llvm.org/docs/LangRef.html#llvm-bswap-intrinsics


Whether the intrinsic does or not, adding support to APInt is pretty trivial. Scarily we don't appear to have any unit tests at all for APInt:byteSwap


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74621/new/

https://reviews.llvm.org/D74621





More information about the llvm-commits mailing list