[PATCH] D74209: [AssumeBundle] Add documentation for the operand bundles of an llvm.assume

[Nuno Lopes via Phabricator via llvm-commits]

nlopes added a comment.

LGTM overall, just some nitpicks.
Something I would add is a link to the list of attributes (is this `function-attributes`?).



================
Comment at: llvm/docs/LangRef.rst:2126
+
+If there are no arguments the attribute is a property of the call location.
+
----------------
which call location?


================
Comment at: llvm/docs/LangRef.rst:2134
+
+allows the optimizer to assume that at this point ``%val`` has an alignment of
+at least 8 and ``%ptr`` has an alignment of at least ``%alignment``.
----------------
nitpick, maybe at this point -> from this point forward
since the assumptions hold for the rest of the program.


================
Comment at: llvm/docs/LangRef.rst:2141
+
+allows the optimizer to assume that the call location is cold and that ``%val``
+may not be null.
----------------
which call location? The one that returns `%cond` or `%val`?  Should be made explicit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74209/new/

https://reviews.llvm.org/D74209