[PATCH] D43470: [DWARF] Prevent crash when .debug_line line_range is zero

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 14 07:55:38 PST 2020


jhenderson updated this revision to Diff 244669.
jhenderson edited the summary of this revision.
jhenderson added reviewers: ikudrin, MaskRay.
jhenderson changed the repository for this revision from rL LLVM to rG LLVM Github Monorepo.
jhenderson added a subscriber: chrisjackson.
jhenderson added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.

Resurrecting this change, by rewriting the fix on the latest HEAD. In this version, the check is done when a special opcode or DW_LNS_const_add_pc is encountered. An Error is reported if the line_range is 0 for the first such instance of these. Testing is now done via unit tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D43470/new/

https://reviews.llvm.org/D43470

Files:
  llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43470.244669.patch
Type: text/x-patch
Size: 8635 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200214/fbafbd57/attachment.bin>


More information about the llvm-commits mailing list