[PATCH] D74367: [llvm-readelf] Print raw ELF note contents if we can't parse it

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I assume that you've verified against GNU readelf all the behaviour that you're changing here?



================
Comment at: llvm/test/tools/llvm-readobj/ELF/gnu-note-size.test:1
 # RUN: yaml2obj %s -o %t
 # RUN: llvm-readelf --notes %t | FileCheck %s --check-prefix=GNU
----------------
It's unclear to me what this test is testing, so I can't really say whether this change is good. Would you mind adding a comment at the top of the test, either in this patch or a different one, briefly explaining its purpose, please? I imagine you might need to dig into the old commit messages for this file to find out.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5129
+      OS << "    <corrupt GNU_ABI_TAG>\n";
+      return false;
+    }
----------------
arichardson wrote:
> It seems like GNU readelf does not print the contents in this case.
Nit: missing trailing full stop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74367/new/

https://reviews.llvm.org/D74367