[PATCH] D74544: [MLIR] Add naive fusion of parallel loops.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 13 23:38:02 PST 2020


mehdi_amini added inline comments.


================
Comment at: mlir/lib/Transforms/ParallelLoopFusion.cpp:137
+static mlir::PassRegistration<mlir::LoopFusion>
+    pass("parallel-loop-fusion", "Fuse parallel loop nests");
----------------
pifon2a wrote:
> mehdi_amini wrote:
> > Can this pass be located under the loop dialect?
> @mehdi_amini Do you mean moving this code to `mlir/lib/Transforms/LoopFusion.cpp` where fusion on affine loops is implemented? That file is quite big already. Or do you mean having it in `Dialect/LoopOps/Transforms` similarly to `Dialect/Linalg/Transforms`? If it is the latter, then there might be several other passes in `lib/Transforms` that have to be moved to respective directories.
yes there are several passes we need to move under their respective dialects.
Most of the affine stuff is not under the affine dialect, because that's how MLIR started at the very beginning, before the dialect folder was even created.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74544/new/

https://reviews.llvm.org/D74544





More information about the llvm-commits mailing list