[PATCH] D73032: [DependenceAnalysis] Memory dependence analysis internal caching mechanism is broken in presence of TBAA (PR42733).

Thu Feb 13 21:29:04 PST 2020

ebrevnov added a comment.

In D73032#1874605 <https://reviews.llvm.org/D73032#1874605>, @john.brawn wrote:

> It looks like the change that introduced isInvariantLoad was reverted in commit 446acafb82b5c116b6c94c11d4ac4db7641fa58d <https://reviews.llvm.org/rG446acafb82b5c116b6c94c11d4ac4db7641fa58d>, so it's a bit hard to review this with current trunk. Is there any problem with memory dependence analysis as it is, or is there a problem only with isInvariantLoad?

I understand you concern, sorry for the inconvenience. I've just landed isInvariantLoad fix and rebased this one. That shouldn't be an issue any more. This problem is completely separate from isInvariantLoad.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73032/new/

https://reviews.llvm.org/D73032