[PATCH] D74540: Rework go bindings so that binding tests work fine

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 13 17:54:51 PST 2020


I just committed something that should bring back llvm-go :)



On Thu, Feb 13, 2020 at 5:52 PM Fangrui Song via Phabricator <
reviews at reviews.llvm.org> wrote:

> MaskRay added a comment.
>
> In D74540#1874534 <https://reviews.llvm.org/D74540#1874534>, @pcc wrote:
>
> > This broke users of the go bindings who were using build.sh, and changed
> the import path for the bindings unnecessarily. Can we please just bring
> back llvm-go as I requested before?
>
>
> @pcc Are you the best one fixing this issue properly :) ?
>
> I guess this patch fixed the
> `/mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/build/test/Bindings/Go/Output/go.test.script:
> line 1: llvm-go: command not found` diagnostic we continuously get from the
> premerge bot, so I still appreciate Serge's work....
> https://reviews.llvm.org/harbormaster/unit/view/3381/
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D74540/new/
>
> https://reviews.llvm.org/D74540
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200213/d6866b83/attachment.html>


More information about the llvm-commits mailing list