[PATCH] D74525: [mlir][DeclarativeParser] Add support for formatting enum attributes in the string form.

[Frank Laub via Phabricator via llvm-commits]

flaub added a comment.

This is great! Would it be possible to parse keywords into enum attrs as well?

Actually, what's the general feeling about using keywords vs strings for enum values? I think I prefer keywords a little more, it's less noisy and its distinguished from an actual string in the textual representation. Also, it seems like LLVM IR has 'keywords' (they aren't wrapped in quotes) for many enums.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74525/new/

https://reviews.llvm.org/D74525