[PATCH] D74242: [CodeGenPrepare] Handle ExtractValueInst in dupRetToEnableTailCallOpts

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 13 15:00:23 PST 2020


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:2111-2113
+      for (auto i = EVI->idx_begin(), e = EVI->idx_end(); i != e; i++)
+        if (*i != 0)
+          return false;
----------------
Carrot wrote:
> arsenm wrote:
> > getIndices() == { 0 }?
> The structure may be nested, so the index array size can be larger than 1.
Can you add a test with this case? ssd::all would also be shorter


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74242/new/

https://reviews.llvm.org/D74242





More information about the llvm-commits mailing list