[PATCH] D74349: [PowerPC][AIX] Spill and restore the non-volatile condition register bits.
Xiangling Liao via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 13 09:01:26 PST 2020
Xiangling_L added inline comments.
================
Comment at: llvm/test/CodeGen/PowerPC/ppc64-crsave.mir:10
+
+# RUN: llc -mtriple powerpc64-unknown-aix-xcoff -x mir -mcpu=pwr7 \
+# RUN: -run-pass=prologepilog --verify-machineinstrs < %s | \
----------------
Usually, the default cpu level we set in the testcase is `pwr4`, can I ask why we want to test `pwr7` here instead?
================
Comment at: llvm/test/CodeGen/PowerPC/ppc64-crsave.mir:15
+# TODO FIXME: We only check the save and restores of the callee saved gpr for
+# ELF becuase AIX callee saved registers haven't been properly implemented yet.
+
----------------
In case we might forget to update the testcase when we support AIX, can we leave an assertion in the code instead?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74349/new/
https://reviews.llvm.org/D74349
More information about the llvm-commits
mailing list