[PATCH] D72685: [PowerPC] Exploit VSX rounding instrs for rint

[Kai Luo via Phabricator via llvm-commits]

lkail accepted this revision.
lkail added a comment.
This revision is now accepted and ready to land.

> I believe the conversion of SNaN to QNaN is expected here. Note that the (current) C standard does not mention support signaling NaNs at all, and does not really ever mention them. This is planned to be fixed with the upcoming C2x version, which explicitly states that "rint" is supposed to implement the IEEE-754 "roundToIntegerExact" function. And that function, like most general functions defined by IEEE-754, is indeed defined to return a QNaN when the input is a SNaN.

Thanks for the information.

Since my concern has been resolved, this patch LGTM. Thanks for exploiting these instructions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72685/new/

https://reviews.llvm.org/D72685