[PATCH] D72736: [AIX] Add improved interface for retrieving load module paths

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 13 13:11:57 PST 2020


hubert.reinterpretcast requested changes to this revision.
hubert.reinterpretcast added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Support/Unix/Path.inc:243
+#elif defined(_AIX)
+  return getLoadModuleFilenameForFunction(MainAddr)->c_str();
 #elif defined(__linux__) || defined(__CYGWIN__) || defined(__gnu_hurd__)
----------------
The "expected" here is not checked for doing the error handling (soft-fail in this case). It appears `LLVM_ENABLE_ABI_BREAKING_CHECKS` would help to catch these.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72736/new/

https://reviews.llvm.org/D72736





More information about the llvm-commits mailing list