[PATCH] D74488: [VFS] Fix vfsoverlay assertion due to RedirectingFileSystem path handling.

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 13 10:43:11 PST 2020


amccarth added a comment.

Thanks for the additional info.

I understand why canonicalize would fail to remove the dot in that case.  I think the fix should be in canonicalize rather than bypassing it.  I have a couple ideas for that.

But first I'm using your example to try to understand how we get in that case on some machines but not others (like mine).  The test for any fix would be specious.

I hope to figure this out and propose a different fix today.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74488/new/

https://reviews.llvm.org/D74488





More information about the llvm-commits mailing list