[PATCH] D73820: [llvm-strip][WebAssembly] Support strip flags

[Derek Schuff via Phabricator via llvm-commits]

dschuff added a comment.

Updated, please take a look.



================
Comment at: llvm/test/tools/llvm-objcopy/wasm/basic-keep.test:7
+# CHECK: Sections:
+# CHECK-NEXT: - Type: TYPE
+# CHECK:      - Type: CUSTOM
----------------
sbc100 wrote:
> So strip-all doesn't apply to the TYPE section?
Currently objcopy only ever touches custom sections. To me it's an open question whether it makes sense to allow it to do anything to the known sections, since they have to be updated together, with a lot more knowledge about wasm.


================
Comment at: llvm/test/tools/llvm-objcopy/wasm/basic-keep.test:11
+# CHECK-NEXT:   Payload: DEADBEEF
+# CHECK-NOT: Section
+
----------------
sbc100 wrote:
> What is this NOT checking for?
Checks that there are no more sections after foo. I'll add a comment.


================
Comment at: llvm/test/tools/llvm-objcopy/wasm/basic-only-section.test:11
+# CHECK-NEXT:   Tools:
+# CHECK-NOT: Section
+
----------------
sbc100 wrote:
> ditto above, what is this checking for?
Added comment here too.


================
Comment at: llvm/test/tools/llvm-objcopy/wasm/strip-debug.test:1
+## Test that debug sections are stripped with --strip-debug
+# RUN: yaml2obj %s -o %t
----------------
sbc100 wrote:
> Can you do a followup that renames all the `.test` files in this directory to `.yaml` .. its more descriptive and enables syntax highlighting .
Maybe? ELF and COFF use .test instead of .yaml


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73820/new/

https://reviews.llvm.org/D73820