[PATCH] D74567: [scudo][standalone] Workaround for full regions on Android

Thu Feb 13 09:56:45 PST 2020

cryptoad marked an inline comment as done.
cryptoad added inline comments.

================
Comment at: compiler-rt/lib/scudo/standalone/combined.h:275
+      // not fail.
+      if (SCUDO_ANDROID && SCUDO_CAN_USE_PRIMARY64) {
+        if (UNLIKELY(!Block)) {
----------------
hctim wrote:
> Why not do this for all platforms?
We had to reduce the region sizes on Android to 256MB, other platforms usually have 1GB or more, which makes them less likely to run out of space in the primary.
Since it only surfaced on Android, I figured I would spare the other platforms the additional code.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74567/new/

https://reviews.llvm.org/D74567