[PATCH] D69665: [llvm-ar] Fix llvm-ar response file reading on Windows

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

The tests are good, and I don't have more questions about Windows. But please mark all addresses issues "done". Click the "Done" button before uploading a Differential. When the Differential is uploaded, all marked comments will be marked "Done".



================
Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:1116
+                 SmallVector<const char *, 0> Args) {
+  StringRef Arg = removeHyphens(*ArgIt);
+  size_t len = Expected.size();
----------------
`removeHyphens` is only used once. Consider inlining it.

I feel a bit strange about removeHyphens. Does it accept an option without a dash?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69665/new/

https://reviews.llvm.org/D69665