[PATCH] D74532: [mlir] Linalg: Extend promotion to non f32 buffers.

[Pierre Oechsel via Phabricator via llvm-commits]

poechsel created this revision.
Herald added subscribers: llvm-commits, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a reviewer: nicolasvasilache.
Herald added a project: LLVM.

Linalg's promotion pass was only supporting f32 buffers due to how the
zero value was build for the `fill` operation.

Moreover, `promoteSubViewOperands` was returning a vector with one entry
per float subview while omitting integer subviews. For a program
with only integer subviews the return vector would be of size 0.
However, `promoteSubViewsOperands` would try to access a non zero
number of entries of this vector, resulting in a sefgault.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74532

Files:
  mlir/include/mlir/Dialect/StandardOps/EDSC/Intrinsics.h
  mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp
  mlir/test/Dialect/Linalg/promote.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74532.244359.patch
Type: text/x-patch
Size: 15742 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200213/f4f2e8d1/attachment.bin>