[PATCH] D72676: [PowerPC] Add the missing InstrAliasing for 64-bit rotate instructions

qshanz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 12 23:47:19 PST 2020


steven.zhang added a comment.

In D72676#1873555 <https://reviews.llvm.org/D72676#1873555>, @jsji wrote:

> Good catch. This looks good to me. However, there are more than these, almost ALL 64 bits OPs are missing InstAlias.. Can we get some general way to support ALL of them, instead of fixing one by one like this?


PowerPC separate the 32bit and 64bit instructions into two files, as we didn't have the general way to define the instructions for 32bit/64bit, it is NOT easy to do it for instr alias also. Maybe, it could be a follow up of this patch ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72676/new/

https://reviews.llvm.org/D72676





More information about the llvm-commits mailing list