[PATCH] D74349: [PowerPC][AIX] Spill and restore the non-volatile condition register bits.

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 12 10:24:44 PST 2020


sfertile updated this revision to Diff 244216.
sfertile marked 6 inline comments as done.
sfertile added a comment.

- Add const on local
- add an assert to express the codegen inside an if is meant for 64-bit only.
- add an `aix-crspill` test which checks the assembly output for both 64-bit and 32-bit AIX.
- Use CHECK-LABEL in aix32-crspill.mir test to restict the scope of other CHECK directives.
- Add checking of the fixed stack object in ppc64-crsave.mir test to match the aix32 test.

Forgot to exetend the alloca test to include 32-bit AIX.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74349/new/

https://reviews.llvm.org/D74349

Files:
  llvm/lib/Target/PowerPC/PPCFrameLowering.cpp
  llvm/lib/Target/PowerPC/PPCFrameLowering.h
  llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp
  llvm/test/CodeGen/PowerPC/aix-crspill.ll
  llvm/test/CodeGen/PowerPC/aix32-crsave.mir
  llvm/test/CodeGen/PowerPC/ppc64-alloca-crspill.ll
  llvm/test/CodeGen/PowerPC/ppc64-crsave.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74349.244216.patch
Type: text/x-patch
Size: 26960 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200212/2c3f8f33/attachment-0001.bin>


More information about the llvm-commits mailing list