[PATCH] D74461: Remove static registration for dialects, and the "alwayslink" hack for passes

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

> to get new Passes and Dialects into the system in a not error-prone way

What kind of error that wouldn’t be trivially found during `ninja check` do you foresee?

In general I agree with all you other comments in this revision, you can see this as an incremental step. I had to land this because I couldn’t get more done and it was important to fix the nasty issue with incremental builds of mlir-opt being broken.

I’d like indeed to look into more unified way of registering passes with their dialect for example.

For the long list of passes, have you seen how LLVM works? 
https://github.com/llvm/llvm-project/blob/master/llvm/include/llvm/LinkAllPasses.h
I did it shamelessly here only because LLVM was as pragmatic... I don’t find it particularly nice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74461/new/

https://reviews.llvm.org/D74461