[PATCH] D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect

[shraiysh via Phabricator via llvm-commits]

shraiysh added inline comments.


================
Comment at: mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:612
+  for (Value v : values) {
+    assert(valueMapping.find(v) != valueMapping.end() &&
+           "referencing undefined value");
----------------
rriddle wrote:
> What prompted this change? Seems unrelated.
In `landingpad` instruction, `valuMapping` was not set. Hence, while trying to make it an operand in `resume`, the program was going into a segmentation fault. I wrote this assert to avoid the segmentation fault.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71888/new/

https://reviews.llvm.org/D71888