[PATCH] D74306: [MIR][ARM] WIP: Print condition code names instead of magic constants

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 12 18:11:15 PST 2020


efriedma added a comment.

This is roughly what I was expecting; I think this is the right approach.

Maybe getImmOperandComment should be a target-specific method, instead of putting the predicate handling logic in target-independent code?  We probably want some general-purpose hook for adding comments anyway.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74306/new/

https://reviews.llvm.org/D74306





More information about the llvm-commits mailing list