[PATCH] D74409: [debuginfo-tests][Dexter] Fix process creation flake-out on Windows

[Greg Bedwell via llvm-commits]

We probably need to use vswhere nowadays:
https://devblogs.microsoft.com/setup/vswhere-is-now-installed-with-visual-studio-2017/


On Wed, 12 Feb 2020 at 19:10, Reid Kleckner via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:

> rnk added a comment.
>
> In D74409#1872084 <https://reviews.llvm.org/D74409#1872084>, @TWeaver
> wrote:
>
> > The windows debug info tests are built with clang and debugged using
> dbgeng atm, so there shouldn't be any overlap with visual studio at all.
> >
> > I'd be very interested to see what the issue is.
>
>
> There are my check-debuginfo logs:
> https://reviews.llvm.org/P8194
>
> I think the VS dependence is here:
>
> https://github.com/llvm/llvm-project/blob/master/debuginfo-tests/dexter/dex/builder/scripts/windows/clang-cl_vs2015.bat#L4
>
>   call "%VS140COMNTOOLS%..\..\VC\bin\amd64\vcvars64.bat"
>
> This would set up the environment so that clang-cl can find MSVC headers
> and libraries. For me, VS140COMNTOOLS is not set, and the later errors are
> probably a downstream consequence of that. I launched a new "developer
> command prompt" for VS 2019 and it also lacks that env var, so I'm not sure
> it can be relied on.
>
> Hopefully that helps.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D74409/new/
>
> https://reviews.llvm.org/D74409
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200212/91e3dd50/attachment.html>