[PATCH] D73971: [docs] Minor updates to DeveloperPolicy due to svn to git

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 12 13:29:01 PST 2020


This revision was automatically updated to reflect the committed changes.
Closed by commit rGbaf3a53b5750: [docs] Minor updates to DeveloperPolicy due to svn to git (authored by jsji).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73971/new/

https://reviews.llvm.org/D73971

Files:
  llvm/docs/DeveloperPolicy.rst


Index: llvm/docs/DeveloperPolicy.rst
===================================================================
--- llvm/docs/DeveloperPolicy.rst
+++ llvm/docs/DeveloperPolicy.rst
@@ -160,7 +160,7 @@
 Developers should participate in code reviews as both reviewers and
 reviewees. If someone is kind enough to review your code, you should return the
 favor for someone else.  Note that anyone is welcome to review and give feedback
-on a patch, but only people with Subversion write access can approve it.
+on a patch, but only people with GitHub commit access can approve it.
 
 There is a web based code review tool that can optionally be used
 for code reviews. See :doc:`Phabricator`.
@@ -325,9 +325,9 @@
   and in-code comments, ex. capitalization, full stop, etc.
 
 * If the commit is a bug fix on top of another recently committed patch, or a
-  revert or reapply of a patch, include the svn revision number of the prior
-  related commit. This could be as simple as "Revert rNNNN because it caused
-  PR#".
+  revert or reapply of a patch, include the git commit hash of the prior
+  related commit. This could be as simple as "Revert commit NNNN because it
+  caused PR#".
 
 For minor violations of these recommendations, the community normally favors
 reminding the contributor of this policy over reverting. Minor corrections and


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73971.244263.patch
Type: text/x-patch
Size: 1336 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200212/de2fc4f0/attachment.bin>


More information about the llvm-commits mailing list