[PATCH] D74375: [ELF] Support INSERT [AFTER|BEFORE] for orphan sections

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 12 10:15:39 PST 2020


nickdesaulniers added inline comments.


================
Comment at: lld/ELF/ScriptParser.cpp:552
+    // TODO This rule will be dropped in the future.
+    config->singleRoRx = true;
+
----------------
MaskRay wrote:
> @srhines @nickdesaulniers I want to delete `config->singleRoRx = true;` in the future to be more consistant with other parts of lld. (It also matches `ld.bfd -z separate-code`)
> 
> Can you please test whether any project needs adaptation with this change?
> 
Sorry, what is the ask? I don't see `separate-code` being used in the Linux kernel. Or are you asking about all of Android (userspace)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74375/new/

https://reviews.llvm.org/D74375





More information about the llvm-commits mailing list