[PATCH] D73887: [DebugInfo] Do not cut 64-bit values when dumping CIEs and FDEs.

Wed Feb 12 08:42:40 PST 2020

probinson added a comment.

Apologies for the slow response.  Overall this seems cleaner than D73714 <https://reviews.llvm.org/D73714>, now that I better understand the subtleties between .debug_frame and .eh_frame specifications.

The commit message should include a link to the Linux spec that you cited in the other review, which will help future readers understand the differences between the two formats.

A couple of minor things inline that I would like to see addressed.

================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h:191
   static bool classof(const FrameEntry *FE) { return FE->getKind() == FK_CIE; }
+  static uint64_t getCIEId(bool IsDWARF64, bool IsEH);

----------------
Because this will not return the value from the data, it should have a comment along the lines of:
`// Returns the CIE identifier to be used by the requested format.`

================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:328
+     << format(" FDE cie=%0*" PRIx64, IsDWARF64 && !IsEH ? 16 : 8,
+               LinkedCIEOffset)
+     << format(" pc=%08" PRIx64 "...%08" PRIx64, InitialLocation,
----------------
This looks like you are printing LinkedCIEOffset twice?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73887/new/

https://reviews.llvm.org/D73887